Skip to content

Add #![feature(ergonomic_clones)] formatting #6532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add #![feature(ergonomic_clones)] formatting #6532

merged 1 commit into from
Apr 2, 2025

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Apr 2, 2025 •
edited
Loading

Tracking issue rust-lang/rust#134797

Closes #6512

@ytmimi ytmimi mentioned this pull request Apr 2, 2025
Closed
@ytmimi
Add #![feature(ergonomic_clones)] formatting
7265718 
Tracking issue r-l/rust#134797

Fixes 6512
@ytmimi ytmimi force-pushed the ergonomic_clones_formatting branch from 7391e74 to 7265718 Compare April 2, 2025 15:02
@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 2, 2025

@spastorino thanks for taking a look at the implementation. I'll go ahead and get this merged now and the formatting will be available in r-l/rust after the next subtree sync, which I hope to get out soon(ish).

@ytmimi ytmimi merged commit cdccf23 into rust-lang:master Apr 2, 2025
30 checks passed
@ytmimi ytmimi deleted the ergonomic_clones_formatting branch April 2, 2025 15:32
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Apr 2, 2025
@spastorino spastorino mentioned this pull request Apr 11, 2025
Draft
@spastorino
Copy link
Member

@spastorino thanks for taking a look at the implementation. I'll go ahead and get this merged now and the formatting will be available in r-l/rust after the next subtree sync, which I hope to get out soon(ish).

I've opened this rust-lang/rust#139692, not sure when this change is going to be used in rust-lang/rust's rustfmt. Please let me know when the sync happens so I can rebase the PR and mark it as ready.

@spastorino
Copy link
Member

@ytmimi I didn't do a proper check to be honest, but I was surprised that this is not yet included in rustfmt 1.8.0-nightly (ce7e97f737 2025-05-11).

@spastorino spastorino mentioned this pull request Jul 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@spastorino spastorino spastorino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-notes Needs an associated changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ergonomic ref counting support
3 participants
@ytmimi @spastorino @rustbot